Xfel striping fix #844
Open
Xfel striping fix #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Disclaimer: I might be unable to find time in the nearest future to fully fix the striping (i.e. read data and stripe it instead of files), but I believe some of the changes suggested here could be useful. |
|
For anyone wandering about implementing real striping experiment-wise: since the striping/chunking script accepts and returns expt/refl paths and not individual experiments + associated reflections, one cannot patch-in real experiment-wise striping without significantly changing the workflow of routines which use it to handle actual objects instead of paths. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce some changes to striping to improve current behavior. In particular, currently
cctbx.xfel.stripe_experimentstripes/chunks expt and refl files instead of actual experiments and reflections. However, since I have prepared the implementation in hurry, "striping" does not stripe anymore, but rather distributes randomly. Also, some improvements to the default parameters have been suggested.