Add time of flight check in Scan.is_still() #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reated as stills.
…est_scan_is_still to test property separate from experiment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #689 +/- ##
=======================================
Coverage 42.14% 42.14%
=======================================
Files 185 185
Lines 16231 16231
Branches 3121 3121
=======================================
Hits 6840 6840
Misses 8759 8759
Partials 632 632 |
toastisme
added a commit
to toastisme/dxtbx
that referenced
this pull request
Jul 18, 2024
Time of flight data does not fully fit in either still or sweeps camp, but in most cases the check is used to distinguish between 2D and 3D data. Within DIALS, time of flight data is being treated as 3D data, with the third dimension being time of flight rather than rotation. Update this check to reflect that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scan.is_still()is currently used in a lot of branching to separate rotational scans from still images that have Scan objects. Time of flight data does not fully fit in either camp, but in most cases the check is used to distinguish between 2D and 3D data. Within DIALS, time of flight data is being treated as 3D data, with the third dimension being time of flight rather than rotation.