Allow distance override for multi-panel detectors #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagewa
added a commit
to dials/dials
that referenced
this pull request
Feb 23, 2024
Requires cctbx/dxtbx#698 to be merged first
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #698 +/- ##
==========================================
+ Coverage 42.39% 42.41% +0.01%
==========================================
Files 186 186
Lines 16362 16423 +61
Branches 3121 3145 +24
==========================================
+ Hits 6937 6965 +28
- Misses 8793 8819 +26
- Partials 632 639 +7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously distance overrides in
dials.importwere restricted to single panel detectors byassert len(detector) == 1. This PR lifts that restriction. If a multi-panel detector has a hierarchy it will have its root node distance set. If there is no hierarchy then each panel will individually have distance set, but only if those panels are coplanar and already at the same distance.