Fix profile, scaling models in Python 3.12 #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #727 +/- ##
=======================================
Coverage 41.81% 41.81%
=======================================
Files 187 187
Lines 16806 16806
Branches 3208 3210 +2
=======================================
Hits 7027 7027
Misses 9133 9133
Partials 646 646 |
toastisme
pushed a commit
to toastisme/dxtbx
that referenced
this pull request
Jul 18, 2024
Because these models are only provided by DIALS, this did not show up in standalone dxtbx testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code exists in dxtbx to load, but only DIALS actively provides implementations, so no test failures were caused.