Fix old I03 data not processing #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #737 +/- ##
==========================================
- Coverage 42.15% 41.73% -0.42%
==========================================
Files 188 188
Lines 16764 16877 +113
Branches 3196 3232 +36
==========================================
- Hits 7067 7044 -23
- Misses 9052 9178 +126
- Partials 645 655 +10 |
This reverts commit 8a57854.
graeme-winter
approved these changes
May 22, 2024
ndevenish
added a commit
that referenced
this pull request
May 23, 2024
Some data taken with the Eiger pre-2020 was written: - With a 64-bit VDS pointing to 32-bit data arrays, - Without the metafile being linked in the main file, - Without the eiger self-reported data type being in the metafile. Solving these allows DIALS to know that the VDS is wrong, and that it is safe to convert down to 32-bit. Soves dials/dials#2669.
Merged
|
Thanks, confirmed I can process that data set now 👍 |
toastisme
pushed a commit
to toastisme/dxtbx
that referenced
this pull request
Jul 18, 2024
Some data taken with the Eiger pre-2020 was written: - With a 64-bit VDS pointing to 32-bit data arrays, - Without the metafile being linked in the main file, - Without the eiger self-reported data type being in the metafile. Solving these allows DIALS to know that the VDS is wrong, and that it is safe to convert down to 32-bit. Soves dials/dials#2669.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This data did not process, because:
_meta.h5file (it was not linked from the.nxs, which was assumed). There is now a fallback that uses pure filename instead of trying to determine it from the main file._meta.h5file didn't have a stored "Detector bit depth" field. This now uses the per-imagebitdepthfield.Fixes dials/dials#2669.