Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: create utils, fix validation #78

Merged
merged 21 commits into from Mar 2, 2019
Merged

MAINT: create utils, fix validation #78

merged 21 commits into from Mar 2, 2019

Conversation

eigenfoo
Copy link
Collaborator

@eigenfoo eigenfoo commented Mar 2, 2019 •
edited

Supersedes #77.

  • Create a utils.py with the CHARACTER array, model saving/loading functions, and raster function.
  • Generate fonts, rasterize and save them as pngs periodically during training.
  • Create a script to run model at inference time, generating more fonts.

Note that fridge.py is no more. Model saving/loading is handled by utils.py, along with a few more handy variables and functions.

@eigenfoo eigenfoo mentioned this pull request Mar 2, 2019
Closed
eigenfoo
eigenfoo commented Mar 2, 2019
View reviewed changes
src/infer.py Outdated Show resolved Hide resolved
@eigenfoo eigenfoo marked this pull request as ready for review March 2, 2019 06:24
@eigenfoo eigenfoo requested a review from ccurro March 2, 2019 21:13
ccurro
ccurro approved these changes Mar 2, 2019
View reviewed changes
Copy link
Owner

@ccurro ccurro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍔

Would like another reviewer though.

@eigenfoo
Copy link
Collaborator Author

eigenfoo commented Mar 2, 2019 •
edited

TODO:

  • Infer with full character sets. This involves fixing matzah. [Jonny]
  • Make sure running infer.py works. [George]
  • Full raster at inference time. [George]

ArianaFreitag
ArianaFreitag reviewed Mar 2, 2019
View reviewed changes
Makefile
@@ -6,6 +6,9 @@ SHELL = bash
init:
find .git/hooks -type l -exec rm {} \;
find .githooks -type f -exec ln -sf ../../{} .git/hooks/ \;
mkdir output/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after we merge to master do we all need to call make init again?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this merges, everyone should immediately pull. This PR changes quite a lot.

@ArianaFreitag ArianaFreitag merged commit c3447f6 into master Mar 2, 2019
@ArianaFreitag ArianaFreitag deleted the fix-validation branch March 2, 2019 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccurro ccurro ccurro approved these changes

@ArianaFreitag ArianaFreitag ArianaFreitag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eigenfoo @ccurro @ArianaFreitag