MEXC: No fee info in watchMyTrades

[mjwvb]

Operating System

MacOS

Programming Languages

JavaScript

CCXT Version

4.2.93

Description

When watching trades using watchMyTrades() the "fee" property is always undefined and thus not yet implemented. Nowadays the fee currency and cost are also sent with the websocket data as "N" (currency) and "n" (cost).
See: https://mexcdevelop.github.io/apidocs/spot_v3_en/#spot-account-deals

Would be nice to have them implemented as well.

Code

My workaround for now:

if (exchange.id === "mexc") {
  const parseWsTradeOriginal = exchange.parseWsTrade;
  exchange.parseWsTrade = function (trade, market) {
    const result = parseWsTradeOriginal.call(this, trade, market);

    if (result.fee === undefined) {
      const feeCurrency = this.safeString(trade, "N");
      const feeCost = this.safeNumber(trade, "n");

      if (feeCurrency !== undefined && feeCost !== undefined) {
        result.fee = {
          currency: feeCurrency,
          cost: feeCost,
        };
      }
    }

    return result;
  };
}

Example trade returned by watchMyTrades:

{
  "info": {
    "p": "141.0135",
    "v": "0.1",
    "a": "14.10135",
    "S": 1,
    "T": 1714305394276,
    "t": "8840627c72fb465a908794d8c4239f6f",
    "c": "SCS-A-95AdsRKSuyapDgRgkRAvH",
    "i": "C02__413235063167901696122",
    "m": 1,
    "st": 0,
    "n": "0.01410135",
    "N": "USDC"
  },
  "id": "8840627c72fb465a908794d8c4239f6f",
  "order": "C02__413235063167901696122",
  "timestamp": 1714305394276,
  "datetime": "2024-04-28T11:56:34.276Z",
  "symbol": "SOL/USDC",
  "type": undefined,
  "side": "buy",
  "takerOrMaker": "maker",
  "price": 141.0135,
  "amount": 0.1,
  "cost": 14.10135,
  "fee": undefined,
  "fees": []
}

[carlosmiei]

Hello @mjwvb,
thanks for reporting it, we will take a look