Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order types #22449

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/transpile.js
Original file line number Diff line number Diff line change
Expand Up @@ -1021,7 +1021,7 @@ class Transpiler {
'Num': /: (?:List\[)?Num =/,
'Option': /-> Option:/,
'OptionChain': /-> OptionChain:/,
'Order': /-> (?:List\[)?Order\]?:/,
'Order': /(-> (?:List\[)?Order\]?:)|(: (?:List\[)?Order)/,
'OrderBook': /-> OrderBook:/,
'OrderRequest': /: (?:List\[)?OrderRequest/,
'CancellationRequest': /: (?:List\[)?CancellationRequest/,
Expand Down
2 changes: 1 addition & 1 deletion python/ccxt/async_support/base/exchange.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
# -----------------------------------------------------------------------------

from ccxt.base.errors import BaseError, BadSymbol, BadRequest, BadResponse, ExchangeError, ExchangeNotAvailable, RequestTimeout, NotSupported, NullResponse, InvalidAddress, RateLimitExceeded
from ccxt.base.types import OrderType, OrderSide, OrderRequest, CancellationRequest
from ccxt.base.types import OrderType, OrderSide, OrderRequest, CancellationRequest, Order

# -----------------------------------------------------------------------------

Expand Down
2 changes: 1 addition & 1 deletion python/ccxt/base/exchange.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
from ccxt.base.decimal_to_precision import DECIMAL_PLACES, TICK_SIZE, NO_PADDING, TRUNCATE, ROUND, ROUND_UP, ROUND_DOWN, SIGNIFICANT_DIGITS
from ccxt.base.decimal_to_precision import number_to_string
from ccxt.base.precise import Precise
from ccxt.base.types import BalanceAccount, Currency, IndexType, OrderSide, OrderType, Trade, OrderRequest, Market, MarketType, Str, Num, Strings, CancellationRequest
from ccxt.base.types import BalanceAccount, Currency, IndexType, OrderSide, OrderType, Trade, OrderRequest, Market, MarketType, Str, Num, Strings, CancellationRequest, Order

# -----------------------------------------------------------------------------

Expand Down
2 changes: 1 addition & 1 deletion ts/src/ace.ts
Original file line number Diff line number Diff line change
Expand Up @@ -642,7 +642,7 @@ export default class ace extends Exchange {
return this.parseOrder (data, market);
}

async cancelOrder (id: string, symbol: Str = undefined, params = {}) {
async cancelOrder (id: string, symbol: Str = undefined, params = {}): Promise<Order> {
/**
* @method
* @name ace#cancelOrder
Expand Down
4 changes: 2 additions & 2 deletions ts/src/alpaca.ts
Original file line number Diff line number Diff line change
Expand Up @@ -775,7 +775,7 @@ export default class alpaca extends Exchange {
return this.parseOrder (order, market);
}

async cancelOrder (id: string, symbol: Str = undefined, params = {}) {
async cancelOrder (id: string, symbol: Str = undefined, params = {}): Promise<Order> {
/**
* @method
* @name alpaca#cancelOrder
Expand All @@ -799,7 +799,7 @@ export default class alpaca extends Exchange {
return this.safeValue (response, 'message', {});
}

async cancelAllOrders (symbol: Str = undefined, params = {}) {
async cancelAllOrders (symbol: Str = undefined, params = {}): Promise<Order[]> {
/**
* @method
* @name alpaca#cancelAllOrders
Expand Down
4 changes: 2 additions & 2 deletions ts/src/ascendex.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2189,7 +2189,7 @@ export default class ascendex extends Exchange {
return this.parseOrders (data, market, since, limit);
}

async cancelOrder (id: string, symbol: Str = undefined, params = {}) {
async cancelOrder (id: string, symbol: Str = undefined, params = {}): Promise<Order> {
/**
* @method
* @name ascendex#cancelOrder
Expand Down Expand Up @@ -2303,7 +2303,7 @@ export default class ascendex extends Exchange {
return this.parseOrder (order, market);
}

async cancelAllOrders (symbol: Str = undefined, params = {}) {
async cancelAllOrders (symbol: Str = undefined, params = {}): Promise<Order[]> {
/**
* @method
* @name ascendex#cancelAllOrders
Expand Down
16 changes: 8 additions & 8 deletions ts/src/base/Exchange.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5181,35 +5181,35 @@ export default class Exchange {
throw new NotSupported (this.id + ' createOrderWs() is not supported yet');
}

async cancelOrder (id: string, symbol: Str = undefined, params = {}): Promise<{}> {
async cancelOrder (id: string, symbol: Str = undefined, params = {}): Promise<Order> {
throw new NotSupported (this.id + ' cancelOrder() is not supported yet');
}

async cancelOrderWs (id: string, symbol: Str = undefined, params = {}): Promise<{}> {
async cancelOrderWs (id: string, symbol: Str = undefined, params = {}): Promise<Order> {
throw new NotSupported (this.id + ' cancelOrderWs() is not supported yet');
}

async cancelOrdersWs (ids: string[], symbol: Str = undefined, params = {}): Promise<{}> {
async cancelOrdersWs (ids: string[], symbol: Str = undefined, params = {}): Promise<Order[]> {
throw new NotSupported (this.id + ' cancelOrdersWs() is not supported yet');
}

async cancelAllOrders (symbol: Str = undefined, params = {}): Promise<{}> {
async cancelAllOrders (symbol: Str = undefined, params = {}): Promise<Order[]> {
throw new NotSupported (this.id + ' cancelAllOrders() is not supported yet');
}

async cancelAllOrdersAfter (timeout: Int, params = {}): Promise<{}> {
async cancelAllOrdersAfter (timeout: Int, params = {}): Promise<Order[]> {
throw new NotSupported (this.id + ' cancelAllOrdersAfter() is not supported yet');
}

async cancelOrdersForSymbols (orders: CancellationRequest[], params = {}): Promise<{}> {
async cancelOrdersForSymbols (orders: CancellationRequest[], params = {}): Promise<Order[]> {
throw new NotSupported (this.id + ' cancelOrdersForSymbols() is not supported yet');
}

async cancelAllOrdersWs (symbol: Str = undefined, params = {}): Promise<{}> {
async cancelAllOrdersWs (symbol: Str = undefined, params = {}): Promise<Order[]> {
throw new NotSupported (this.id + ' cancelAllOrdersWs() is not supported yet');
}

async cancelUnifiedOrder (order, params = {}): Promise<{}> {
async cancelUnifiedOrder (order: Order, params = {}): Promise<Order> {
return this.cancelOrder (this.safeString (order, 'id'), this.safeString (order, 'symbol'), params);
}

Expand Down
4 changes: 2 additions & 2 deletions ts/src/bigone.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1565,7 +1565,7 @@ export default class bigone extends Exchange {
return this.parseOrder (order, market);
}

async cancelOrder (id: string, symbol: Str = undefined, params = {}) {
async cancelOrder (id: string, symbol: Str = undefined, params = {}): Promise<Order> {
/**
* @method
* @name bigone#cancelOrder
Expand Down Expand Up @@ -1595,7 +1595,7 @@ export default class bigone extends Exchange {
return this.parseOrder (order);
}

async cancelAllOrders (symbol: Str = undefined, params = {}) {
async cancelAllOrders (symbol: Str = undefined, params = {}): Promise<Order[]> {
/**
* @method
* @name bigone#cancelAllOrders
Expand Down
4 changes: 2 additions & 2 deletions ts/src/binance.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6855,7 +6855,7 @@ export default class binance extends Exchange {
return this.filterBySinceLimit (sortedOrders, since, limit);
}

async cancelOrder (id: string, symbol: Str = undefined, params = {}) {
async cancelOrder (id: string, symbol: Str = undefined, params = {}): Promise<Order> {
/**
* @method
* @name binance#cancelOrder
Expand Down Expand Up @@ -6949,7 +6949,7 @@ export default class binance extends Exchange {
return this.parseOrder (response, market);
}

async cancelAllOrders (symbol: Str = undefined, params = {}) {
async cancelAllOrders (symbol: Str = undefined, params = {}): Promise<Order[]> {
/**
* @method
* @name binance#cancelAllOrders
Expand Down
6 changes: 3 additions & 3 deletions ts/src/bingx.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2521,7 +2521,7 @@ export default class bingx extends Exchange {
return this.safeString (statuses, status, status);
}

async cancelOrder (id: string, symbol: Str = undefined, params = {}) {
async cancelOrder (id: string, symbol: Str = undefined, params = {}): Promise<Order> {
/**
* @method
* @name bingx#cancelOrder
Expand Down Expand Up @@ -2607,7 +2607,7 @@ export default class bingx extends Exchange {
return this.parseOrder (first, market);
}

async cancelAllOrders (symbol: Str = undefined, params = {}) {
async cancelAllOrders (symbol: Str = undefined, params = {}): Promise<Order[]> {
/**
* @method
* @name bingx#cancelAllOrders
Expand Down Expand Up @@ -2767,7 +2767,7 @@ export default class bingx extends Exchange {
return response;
}

async cancelAllOrdersAfter (timeout: Int, params = {}) {
async cancelAllOrdersAfter (timeout: Int, params = {}): Promise<Order[]> {
/**
* @method
* @name bingx#cancelAllOrdersAfter
Expand Down
2 changes: 1 addition & 1 deletion ts/src/bit2c.ts
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,7 @@ export default class bit2c extends Exchange {
return this.parseOrder (response, market);
}

async cancelOrder (id: string, symbol: Str = undefined, params = {}) {
async cancelOrder (id: string, symbol: Str = undefined, params = {}): Promise<Order> {
/**
* @method
* @name bit2c#cancelOrder
Expand Down
2 changes: 1 addition & 1 deletion ts/src/bitbank.ts
Original file line number Diff line number Diff line change
Expand Up @@ -685,7 +685,7 @@ export default class bitbank extends Exchange {
return this.parseOrder (data, market);
}

async cancelOrder (id: string, symbol: Str = undefined, params = {}) {
async cancelOrder (id: string, symbol: Str = undefined, params = {}): Promise<Order> {
/**
* @method
* @name bitbank#cancelOrder
Expand Down
2 changes: 1 addition & 1 deletion ts/src/bitbns.ts
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,7 @@ export default class bitbns extends Exchange {
return this.parseOrder (response, market);
}

async cancelOrder (id: string, symbol: Str = undefined, params = {}) {
async cancelOrder (id: string, symbol: Str = undefined, params = {}): Promise<Order> {
/**
* @method
* @name bitbns#cancelOrder
Expand Down
4 changes: 2 additions & 2 deletions ts/src/bitfinex.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1159,7 +1159,7 @@ export default class bitfinex extends Exchange {
return this.parseOrder (response);
}

async cancelOrder (id: string, symbol: Str = undefined, params = {}) {
async cancelOrder (id: string, symbol: Str = undefined, params = {}): Promise<Order> {
/**
* @method
* @name bitfinex#cancelOrder
Expand All @@ -1177,7 +1177,7 @@ export default class bitfinex extends Exchange {
return await this.privatePostOrderCancel (this.extend (request, params));
}

async cancelAllOrders (symbol: Str = undefined, params = {}) {
async cancelAllOrders (symbol: Str = undefined, params = {}): Promise<Order[]> {
/**
* @method
* @name bitfinex#cancelAllOrders
Expand Down
4 changes: 2 additions & 2 deletions ts/src/bitfinex2.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1798,7 +1798,7 @@ export default class bitfinex2 extends Exchange {
return this.parseOrders (results);
}

async cancelAllOrders (symbol: Str = undefined, params = {}) {
async cancelAllOrders (symbol: Str = undefined, params = {}): Promise<Order[]> {
/**
* @method
* @name bitfinex2#cancelAllOrders
Expand All @@ -1817,7 +1817,7 @@ export default class bitfinex2 extends Exchange {
return this.parseOrders (orders);
}

async cancelOrder (id: string, symbol: Str = undefined, params = {}) {
async cancelOrder (id: string, symbol: Str = undefined, params = {}): Promise<Order> {
/**
* @method
* @name bitfinex2#cancelOrder
Expand Down
2 changes: 1 addition & 1 deletion ts/src/bitflyer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -586,7 +586,7 @@ export default class bitflyer extends Exchange {
});
}

async cancelOrder (id: string, symbol: Str = undefined, params = {}) {
async cancelOrder (id: string, symbol: Str = undefined, params = {}): Promise<Order> {
/**
* @method
* @name bitflyer#cancelOrder
Expand Down
4 changes: 2 additions & 2 deletions ts/src/bitget.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4669,7 +4669,7 @@ export default class bitget extends Exchange {
return this.parseOrder (data, market);
}

async cancelOrder (id: string, symbol: Str = undefined, params = {}) {
async cancelOrder (id: string, symbol: Str = undefined, params = {}): Promise<Order> {
/**
* @method
* @name bitget#cancelOrder
Expand Down Expand Up @@ -4895,7 +4895,7 @@ export default class bitget extends Exchange {
return this.parseOrders (orders, market);
}

async cancelAllOrders (symbol: Str = undefined, params = {}) {
async cancelAllOrders (symbol: Str = undefined, params = {}): Promise<Order[]> {
/**
* @method
* @name bitget#cancelAllOrders
Expand Down
4 changes: 2 additions & 2 deletions ts/src/bithumb.ts
Original file line number Diff line number Diff line change
Expand Up @@ -956,7 +956,7 @@ export default class bithumb extends Exchange {
return this.parseOrders (data, market, since, limit);
}

async cancelOrder (id: string, symbol: Str = undefined, params = {}) {
async cancelOrder (id: string, symbol: Str = undefined, params = {}): Promise<Order> {
/**
* @method
* @name bithumb#cancelOrder
Expand Down Expand Up @@ -987,7 +987,7 @@ export default class bithumb extends Exchange {
return await this.privatePostTradeCancel (this.extend (request, params));
}

async cancelUnifiedOrder (order, params = {}) {
async cancelUnifiedOrder (order: Order, params = {}): Promise<Order> {
const request = {
'side': order['side'],
};
Expand Down
4 changes: 2 additions & 2 deletions ts/src/bitmart.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2573,7 +2573,7 @@ export default class bitmart extends Exchange {
return this.extend (request, params);
}

async cancelOrder (id: string, symbol: Str = undefined, params = {}) {
async cancelOrder (id: string, symbol: Str = undefined, params = {}): Promise<Order> {
/**
* @method
* @name bitmart#cancelOrder
Expand Down Expand Up @@ -2662,7 +2662,7 @@ export default class bitmart extends Exchange {
return this.extend (order, { 'id': id });
}

async cancelAllOrders (symbol: Str = undefined, params = {}) {
async cancelAllOrders (symbol: Str = undefined, params = {}): Promise<Order[]> {
/**
* @method
* @name bitmart#cancelAllOrders
Expand Down
6 changes: 3 additions & 3 deletions ts/src/bitmex.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2018,7 +2018,7 @@ export default class bitmex extends Exchange {
return this.parseOrder (response);
}

async cancelOrder (id: string, symbol: Str = undefined, params = {}) {
async cancelOrder (id: string, symbol: Str = undefined, params = {}): Promise<Order> {
/**
* @method
* @name bitmex#cancelOrder
Expand Down Expand Up @@ -2076,7 +2076,7 @@ export default class bitmex extends Exchange {
return this.parseOrders (response);
}

async cancelAllOrders (symbol: Str = undefined, params = {}) {
async cancelAllOrders (symbol: Str = undefined, params = {}): Promise<Order[]> {
/**
* @method
* @name bitmex#cancelAllOrders
Expand Down Expand Up @@ -2136,7 +2136,7 @@ export default class bitmex extends Exchange {
return this.parseOrders (response, market);
}

async cancelAllOrdersAfter (timeout: Int, params = {}) {
async cancelAllOrdersAfter (timeout: Int, params = {}): Promise<Order[]> {
/**
* @method
* @name bitmex#cancelAllOrdersAfter
Expand Down
4 changes: 2 additions & 2 deletions ts/src/bitopro.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1066,7 +1066,7 @@ export default class bitopro extends Exchange {
return this.parseOrder (response, market);
}

async cancelOrder (id: string, symbol: Str = undefined, params = {}) {
async cancelOrder (id: string, symbol: Str = undefined, params = {}): Promise<Order> {
/**
* @method
* @name bitopro#cancelOrder
Expand Down Expand Up @@ -1132,7 +1132,7 @@ export default class bitopro extends Exchange {
return response;
}

async cancelAllOrders (symbol: Str = undefined, params = {}) {
async cancelAllOrders (symbol: Str = undefined, params = {}): Promise<Order[]> {
/**
* @method
* @name bitopro#cancelAllOrders
Expand Down
4 changes: 2 additions & 2 deletions ts/src/bitrue.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2265,7 +2265,7 @@ export default class bitrue extends Exchange {
return this.parseOrders (data, market, since, limit);
}

async cancelOrder (id: string, symbol: Str = undefined, params = {}) {
async cancelOrder (id: string, symbol: Str = undefined, params = {}): Promise<Order> {
/**
* @method
* @name bitrue#cancelOrder
Expand Down Expand Up @@ -2335,7 +2335,7 @@ export default class bitrue extends Exchange {
return this.parseOrder (data, market);
}

async cancelAllOrders (symbol: Str = undefined, params = {}) {
async cancelAllOrders (symbol: Str = undefined, params = {}): Promise<Order[]> {
/**
* @method
* @name bitrue#cancelAllOrders
Expand Down
4 changes: 2 additions & 2 deletions ts/src/bitso.ts
Original file line number Diff line number Diff line change
Expand Up @@ -999,7 +999,7 @@ export default class bitso extends Exchange {
}, market);
}

async cancelOrder (id: string, symbol: Str = undefined, params = {}) {
async cancelOrder (id: string, symbol: Str = undefined, params = {}): Promise<Order> {
/**
* @method
* @name bitso#cancelOrder
Expand Down Expand Up @@ -1055,7 +1055,7 @@ export default class bitso extends Exchange {
return orders;
}

async cancelAllOrders (symbol: Str = undefined, params = {}) {
async cancelAllOrders (symbol: Str = undefined, params = {}): Promise<Order[]> {
/**
* @method
* @name bitso#cancelAllOrders
Expand Down
Loading