Some codestyle fixes #3646
Some codestyle fixes #3646
Conversation
| ratelImit: 1500, | ||
| version: 'v2', | ||
| has: { | ||
| publicaPI: false, |
There was a problem hiding this comment.
↑ oops )
Btw, you would make it much easier for me to merge if you could split this into several atomic PRs, otherwise it will quickly run into a conflict with ongoing changes.
Thx anyways!
| }, | ||
| 'timeframes': { | ||
| '1m': '60', // not working for some reason, returns {"server_time":"2018-03-26T03:52:27.912Z","error":true,"warning":false,"response":null,"error_code":-1,"error_message":"Error while trying to fetch historical market data. An invalid resolution was probably used."} | ||
| timeframes: { |
There was a problem hiding this comment.
This won't transpile to other languages, unfortunately...
There was a problem hiding this comment.
Meaning the missing quotes here, an unquoted key won't go into Python properly.
| bid: undefined, | ||
| bidvOlume: undefined, | ||
| ask: undefined, | ||
| askvOlume: undefined, |
There was a problem hiding this comment.
↑ Something is broken here and everywhere else, basically... Here it's broken twice: the name should be askVolume, and the quotes should be in place, otherwise it won't work in Python nor in PHP.
|
Plz read this carefully: https://github.com/ccxt/ccxt/blob/master/CONTRIBUTING.md#derived-exchange-classes ) |
| , stringToBase'64': string => CryptoJS.enc.Latin1.parse (string).toString (CryptoJS.enc.Base64) | ||
| , utf'16ToBase64': string => CryptoJS.enc.Utf16 .parse (string).toString (CryptoJS.enc.Base64) | ||
| , base'64ToBinary': string => CryptoJS.enc.Base64.parse (string) | ||
| , base'64ToString': string => CryptoJS.enc.Base64.parse (string).toString (CryptoJS.enc.Utf8) |
There was a problem hiding this comment.
↑ This also isn't a good sign )
| 'assets/currencies', | ||
| 'assets/pairs', | ||
| 'ticker', | ||
| 'orderbook', | ||
| 'trades', | ||
| ], | ||
| ], |
There was a problem hiding this comment.
Removing the space before this bracket will destroy Python padding, unfortunately...
|
You want me to fix them? Or not? Do you have a telegram? |
|
I'd be very thankful if you would rather focus on our pending tasks: https://github.com/ccxt/ccxt/blob/master/CONTRIBUTING.md#pending-tasks ;) Basically, the code styling there is such that is compatible with most of languages with a JSON-like type structure. So, every quote and space counts. Thus, there's actually very little freedom for "styling", just because of the requirements to keep it portable across languages. I would not bother (unless you know all three of JS, Python and PHP or a common subset of all of them). But anyways, if you want to give it a try and want to get a feeling of how the transpiler works, why not, just make sure to read the CONTRIBUTING doc. ) Do you mind if I close this for now? You can resubmit another one anytime later if you want. |
|
Check this out sergeysova/telegram-typings#23 |
No description provided.