controller.rb : prevent re-parsing the script when only its access ti…

…me changes.
cczona · Dec 31, 2010 · ec6cdb9 · ec6cdb9
1 parent 17fa9bf
commit ec6cdb9
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/watchr/controller.rb b/lib/watchr/controller.rb
@@ -59,7 +59,7 @@ def update(path, event_type = nil)
       path = Pathname(path).expand_path
 
       Watchr.debug("received #{event_type.inspect} event for #{path.relative_path_from(Pathname(Dir.pwd))}")
-      if path == @script.path
+      if path == @script.path && event_type != :accessed
         @script.parse!
         @handler.refresh(monitored_paths)
       else

diff --git a/test/test_controller.rb b/test/test_controller.rb
@@ -109,5 +109,13 @@ def setup
     @handler.stubs(:listen).raises(Interrupt)
     @controller.run
   end
+
+  test "does not parse script on mere script file access" do
+    path = to_p('abc')
+    @script.stubs(:path).returns(path)
+    @script.expects(:parse!).never
+
+    @controller.update('abc', :accessed)
+  end
 end