-
Notifications
You must be signed in to change notification settings - Fork 11
Integrate changes of noise aware simulation #72
Conversation
# Conflicts: # CMakeLists.txt # include/dd/Package.hpp
Codecov Report
@@ Coverage Diff @@
## main #72 +/- ##
=======================================
- Coverage 95.8% 95.7% -0.1%
=======================================
Files 19 20 +1
Lines 3462 3800 +338
=======================================
+ Hits 3318 3640 +322
- Misses 144 160 +16
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for all the work.
I have a couple of really minor comments. These shouldn't take long to implement at all. Most are just discussions about proper naming and proper types.
A major concern is, that the functionality of the new class (at least at the moment) depends on the enums from the QFR. This is somewhat ugly (and also one of the main reasons the package does not compile at the moment).
I would argue that it would be perfectly fine to take this class and move it to the include/dd
part of the QFR.
Then you can even define the StochasticNoisePackage
there and provide it as a default argument for the newly created class.
Seems to me as if this would solve all the problems.
It's probably for the best to quickly work through all the comments here, commit them and resolve the comments. Then take the class and move it to the QFR.
reformat moving functionality from deterministic simulator to other places
Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
… unique table Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we are almost done with this. Just a couple more remarks and requests here and there. Should be nothing major.
One thing GitHub wouldn't let me annotate inline:
The coverage seems to indicate that density matrices are never added? can the corresponding compute table be removed entirely?
Also, please give this PR a proper name and add a description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one tiny little remark which needs to be fixed, but after that, I would gladly merge this PR 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and ready to merge 🥳 I'll merge once the other PRs are fully reviewed.
Happy to hear. It took some time and I am happy with the result. Thank you for your (quick) feedback and suggestions. @burgholzer |
This PR adds the latest changes of the noise aware quantum circuit simulation to the DDPackage.
More precisely, this includes functionality of the stochastic noise aware quantum circuit simulator (mainly caching of operations) and functionality of the deterministic noise aware quantum circuit simulator (a new node type, multiplication and addition for the new node type and caching of noise operations.).