Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚗️ Try to get rid of the start parameter in DD routines #345

Closed
burgholzer opened this issue Jun 15, 2023 · 0 comments · Fixed by #574
Closed

⚗️ Try to get rid of the start parameter in DD routines #345

burgholzer opened this issue Jun 15, 2023 · 0 comments · Fixed by #574
Labels
code quality Code quality improvements DD Anything related to the DD package refactor Anything related to code refactoring
Milestone
DD Package Improv...

Comments

@burgholzer
Copy link
Member

burgholzer commented Jun 15, 2023 •
edited
Loading

Many of the DD routines throughout the package include a start parameter that is supposed to indicate the lowest index in the DD. This was mainly introduced for the Hybrid Schrödinger-Feynman (HSF) simulator and isn't used anywhere else.
As such, it is kind of a nuisance and leads to a lot of special handling throughout some of the functions.

It should be possible to work around this requirement by refactoring parts of the HSF simulator in conjunction with the package code here.

Related upstream-stream issue:
@burgholzer burgholzer added refactor Anything related to code refactoring code quality Code quality improvements DD Anything related to the DD package labels Jun 15, 2023
@burgholzer burgholzer added this to the DD Package Improvements milestone Jun 15, 2023
@burgholzer burgholzer mentioned this issue Jun 15, 2023
Open
@burgholzer burgholzer linked a pull request Mar 26, 2024 that will close this issue
♻️ Eliminate nqubits and startingQubit from Operation class hierarchy #574
Merged
4 tasks
@burgholzer burgholzer mentioned this issue Mar 26, 2024
Merged
4 tasks
burgholzer added a commit that referenced this issue Mar 26, 2024
@burgholzer
♻️ Eliminate nqubits and startingQubit from Operation class hie…
3c07991 
…rarchy (#574)

## Description

The third follow-up PRs to #358, which tries to simplify the `Operation`
class hierarchy by eliminating the `nqubits` and `startingQubit`
members, which were purely in place for managing the corresponding
decision diagrams.

This also practically fixes #345. Only state creation routines now have
the additional starting qubit parameter.

## Checklist:

<!---
This checklist serves as a reminder of a couple of things that ensure
your pull request will be merged swiftly.
-->

- [x] The pull request only contains commits that are related to it.
- [x] I have added appropriate tests and documentation.
- [x] I have made sure that all CI jobs on GitHub pass.
- [x] The pull request introduces no new warnings and follows the
project's style guidelines.

---------

Signed-off-by: burgholzer <burgholzer@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Code quality improvements DD Anything related to the DD package refactor Anything related to code refactoring
Projects
MQT
Status: Done
MQT Core
Status: Done
Milestone
DD Package Improvements
Development

Successfully merging a pull request may close this issue.

♻️ Eliminate nqubits and startingQubit from Operation class hierarchy cda-tum/mqt-core
1 participant
@burgholzer