Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃┕ Reusable workflow corrections #433

Merged
merged 3 commits into from
Sep 29, 2023
Merged

馃┕ Reusable workflow corrections #433

merged 3 commits into from
Sep 29, 2023

Conversation

burgholzer
Copy link
Member

Description

This PR fixes a few oversights in the reusable workflows that might have caused some unintended side effects.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer
馃┕ fix python packaging conditions
77841df 
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer
馃┕ fix CodeQL c&p error
78261c3 
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer
馃敟 remove leftover config setting
4664399 
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer added continuous integration Anything related to the CI setup fix Fix for something that isn't working labels Sep 29, 2023
@burgholzer burgholzer added this to the MQT Core milestone Sep 29, 2023
@burgholzer burgholzer self-assigned this Sep 29, 2023
pehamTom
pehamTom approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@pehamTom pehamTom left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pehamTom pehamTom merged commit cb34865 into main Sep 29, 2023
12 checks passed
@pehamTom pehamTom deleted the reusable-workflow-corrections branch September 29, 2023 10:31
@EliasLF EliasLF mentioned this pull request Oct 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pehamTom pehamTom pehamTom approved these changes

Assignees

@burgholzer burgholzer

Labels
continuous integration Anything related to the CI setup fix Fix for something that isn't working
Projects
MQT
Status: Done
MQT Core
Status: Done
Milestone
MQT Core
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@burgholzer @pehamTom