✨ Support for Neutral Atom Mapper #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burgholzer
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Many thanks for the iteration on the code. This looks good to me now. 🎉
I have a couple of minor suggestions for small edits which I will just quickly batch up.
A couple other comments are rather for future reference. Would be nice if you could comment on those and maybe turn them into issues if applicable.
Before merging, let's wait for the upstream PR to be ready.
This was referenced Apr 30, 2024
Co-authored-by: Lukas Burgholzer <burgholzer@me.com>
|
pre-commit.ci run |
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes all modifications and data structures that are generally useful and required for the implementation of the neutral atom mapper, see mqt-qmap#417.
Checklist: