Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦 smaller Python wheels #397

Merged
merged 1 commit into from
May 24, 2024
Merged

📦 smaller Python wheels #397

merged 1 commit into from
May 24, 2024

Conversation

burgholzer
Copy link
Member

Description

This PR reduces the binary wheel size for the project by only installing the specific python bindings CMake component.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer self-assigned this May 24, 2024
@burgholzer burgholzer added python Anything related to Python code packaging Anything related to Python packaging labels May 24, 2024
@burgholzer burgholzer enabled auto-merge (squash) May 24, 2024 12:08
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.1%. Comparing base (ee6be25) to head (1e1f6de).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #397   +/-   ##
=====================================
  Coverage   96.0%   96.1%           
=====================================
  Files         35      35           
  Lines       1818    1818           
  Branches     224     224           
=====================================
+ Hits        1747    1748    +1     
+ Misses        71      70    -1     
Flag Coverage Δ
cpp 95.8% <ø> (+<0.1%) ⬆️
python 97.2% <ø> (ø)

see 1 file with indirect coverage changes

@burgholzer burgholzer merged commit 06e1ff7 into main May 24, 2024
35 checks passed
@burgholzer burgholzer deleted the smaller-wheels branch May 24, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging Anything related to Python packaging python Anything related to Python code
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant