-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link to landing page #218
Link to landing page #218
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
=====================================
Coverage 84.5% 84.6%
=====================================
Files 25 25
Lines 2023 2023
Branches 191 191
=====================================
+ Hits 1711 1712 +1
+ Misses 312 311 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple of small comments.
Note that you might also want to take this opportunity to add Acks to the RtD pages. You should be able to adapt that from the other projects as well.
The test failures here are unrelated. They are due to GitHub moving macOS-latest to ARM runners. I'll quickly fix that up later. |
See #219 |
thank you sm! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm 👍🏻👍🏻
Description
Adds link to mqt landing page in logo and acknowledgements.
Reference PR: cda-tum/mqt-core#469.
Checklist: