Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to landing page #218

Merged
merged 8 commits into from
Apr 29, 2024
Merged

Link to landing page #218

merged 8 commits into from
Apr 29, 2024

Conversation

lucasberent
Copy link
Collaborator

@lucasberent lucasberent commented Apr 25, 2024

Description

Adds link to mqt landing page in logo and acknowledgements.

Reference PR: cda-tum/mqt-core#469.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.6%. Comparing base (831a76c) to head (c8e5e6c).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #218   +/-   ##
=====================================
  Coverage   84.5%   84.6%           
=====================================
  Files         25      25           
  Lines       2023    2023           
  Branches     191     191           
=====================================
+ Hits        1711    1712    +1     
+ Misses       312     311    -1     
Flag Coverage Δ
cpp 79.5% <ø> (ø)
python 88.6% <ø> (+<0.1%) ⬆️

see 1 file with indirect coverage changes

Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of small comments.

Note that you might also want to take this opportunity to add Acks to the RtD pages. You should be able to adapt that from the other projects as well.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@burgholzer
Copy link
Member

The test failures here are unrelated. They are due to GitHub moving macOS-latest to ARM runners. I'll quickly fix that up later.

@burgholzer
Copy link
Member

The test failures here are unrelated. They are due to GitHub moving macOS-latest to ARM runners. I'll quickly fix that up later.

See #219

@burgholzer burgholzer added the documentation Improvements or additions to documentation label Apr 26, 2024
@lucasberent
Copy link
Collaborator Author

The test failures here are unrelated. They are due to GitHub moving macOS-latest to ARM runners. I'll quickly fix that up later.

See #219

thank you sm!

Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍🏻👍🏻

@burgholzer burgholzer enabled auto-merge (squash) April 29, 2024 09:55
@burgholzer burgholzer merged commit ea6d44e into main Apr 29, 2024
28 checks passed
@burgholzer burgholzer deleted the acks branch April 29, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants