PHP ecosystem catch up #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @augustohp Great idea. |
I can definitely help. 😄 |
augustohp
changed the title
Updates the usage of the mock API. PHPUnit 5 is the current stable release so upgrading this will ensure a bigger life time to the test suite. The constraint on `composer.json` still uses 4.8 as version as it is still compatible with PHP 5.3, the intention is to tag a 1.0 version of this package with PHP 5.3 compatibility to later drop it. Creates scripts to ease tests during development and continuous integration. Bootstrapping can be done completely via Composer and PHPUnit configuration. Configures a [build matrix][1] for Travis: * Favor an environment variable to disable TLS. * Mark non maintained PHP versions as allowed failures. * Favor composer scripts instead of commands. * Only send coverage after a success. There are still problems needing fixes regarding the test suite, they need to be addressed separately as they will cause bigger conflicts while merging this code with other (pending) contributions: * Some test cases without the suffix `Test.php` are not being executed. * Avoid exclusion of functional tests. * Separate test cases directory from concrete classes being used. [1]: https://docs.travis-ci.com/user/customizing-the-build/#Build-Matrix
No tests in this suite were executed, anyway. We can always recover them from the version control system, but maybe we will never do that since unit tests are way better. In order to have functional tests, one would still need to solve the issue of authentication. Providing a token for continuous integration would expose that token to anyone, which is not cool even if the user is just intended for that.
Without the suffix "Test.php" in the file names, they were being ignored. Some fixes and cleanup were made but the majority of the tests do not rely on real responses from the Trello API, which needs to be fixed on a next occasion - therefore the @todos added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch up with the PHP ecosystem after 2 years, the idea is to update what we can without braking current compatibility and tag a stable version
1.0of the library.1.0release compatible with PHP 5.3).Test.phpare not being executed.