Optionally enable salt-minion
#239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdalvaro
added
enhancement
cdalvaro
force-pushed
the
feature/optionally-enable-salt-minion
branch
2 times, most recently
from
65fff4e
to
2b4a6f0
Compare
|
Hi @abhi1693, could you build this branch and test it with your settings to make sure this development covers your requirements? Edit: Simply clone this branch and execute: |
cdalvaro
force-pushed
the
feature/optionally-enable-salt-minion
branch
from
2b4a6f0
to
0b18e45
Compare
cdalvaro
force-pushed
the
feature/optionally-enable-salt-minion
branch
from
0b18e45
to
ed4281c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for running a
salt-minioninside the container.The service is disabled by default, but it can be enabled using the environment variable
SALT_MINION_ENABLED=True.Additionally, this PR renames the env variable
SALT_API_SERVICE_ENABLEDtoSALT_API_ENABLED(for consistency with the new env variable). Backward compatibility will be provided until3007.2.More details will be provided as new commits are added...
Closes #237