Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose targetTag for PromoteImage #4

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Expose targetTag for PromoteImage #4

merged 1 commit into from
Mar 5, 2020

Conversation

Emilio-Pega
Copy link
Contributor

@Emilio-Pega Emilio-Pega commented Mar 5, 2020

The Docker PromteImage logic is missing the ability to set the target tag. This is required when we want to promote a CI build image like 1.0.0-1234 to a final image 1.0.0 without needing to pull, retag, and push the image.

Screenshot from 2020-03-05 07-55-21

closes #3

@cdancy cdancy self-requested a review March 5, 2020 14:04
@cdancy cdancy merged commit 3070dbb into cdancy:master Mar 5, 2020
@cdancy
Copy link
Owner

cdancy commented Mar 5, 2020

Running integration tests now to ensure all works as expected and will kick a new release shortly.

@cdancy cdancy added this to the v0.9.8 milestone Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker PromteImage should allow targetTag to be set
2 participants