Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr/173 #174

Merged
merged 3 commits into from
Feb 16, 2019
Merged

Pr/173 #174

merged 3 commits into from
Feb 16, 2019

Conversation

cdancy
Copy link
Owner

@cdancy cdancy commented Feb 16, 2019

Taking this PR in favor of #173

@cdancy cdancy added this to the v2.4.2 milestone Feb 16, 2019
@cdancy cdancy self-assigned this Feb 16, 2019
@cdancy
Copy link
Owner Author

cdancy commented Feb 16, 2019

@adam-tylr not sure if you hit similar issues but I had trouble running the FileApiLiveTests due to commits not being properly pushed. Not sure what the deal is there so I'll have to circle back around. Your code however looks good and worked as expected.

@cdancy cdancy merged commit be4d311 into master Feb 16, 2019
@cdancy
Copy link
Owner Author

cdancy commented Feb 16, 2019

Version 2.4.2 has been released with these changes. Let me know how things go.

@adam-tylr
Copy link
Contributor

@cdancy thanks for creating a release. I didn't have any trouble with the live tests. I don't know what happened there.

@cdancy
Copy link
Owner Author

cdancy commented Feb 16, 2019

Maybe it was environmental on my part. IDK. The code was good though which is all that matters. Thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants