use correct data formats in InsightReportData value #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The same integration tests are failing for me on master, so it's probably something with my local bitbucket instance. |
|
@succcubbus got it working here locally. Will merge this in, apply fix, and kick a new point release. Thanks for the PR! |
|
FWIW: had to massage the test to include less than or equal to 6 items in the |
|
Version |
|
whoa that was fast |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Code Insight ReportData of DataTypes other than TEXT should now work
closes #208
During live testing I got a few
*** Please tell me who you are.messages, and I don't know how to fix these.So the live tests could be broken.