Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bitbucket Server: Search API (/rest/search/{version}/search) #242

Merged
merged 2 commits into from
Oct 27, 2020
Merged

Bitbucket Server: Search API (/rest/search/{version}/search) #242

merged 2 commits into from
Oct 27, 2020

Conversation

thlaegler
Copy link

Implementation of Feature Search API: #241

@thlaegler thlaegler marked this pull request as ready for review October 17, 2020 07:34
@cdancy cdancy self-requested a review October 21, 2020 18:14
@cdancy cdancy self-assigned this Oct 21, 2020
@cdancy cdancy added this to the v2.7.1 milestone Oct 21, 2020
@cdancy cdancy linked an issue Oct 21, 2020 that may be closed by this pull request
Feature: Search API #241
Closed
cdancy
cdancy approved these changes Oct 21, 2020
View reviewed changes
Copy link
Owner

@cdancy cdancy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thlaegler I'm fine with this. Anything else you want to add or do here?

@thlaegler
Copy link
Author

I'm fine with it. Would be good to test it against other Bitbucket versions. Maybe even Bitbucket Cloud.

@cdancy
Copy link
Owner

cdancy commented Oct 21, 2020

@thlaegler what did you test against? We have v7.4.0 here that I can run against.

Also ... would it make sense to allow for passing in a raw string to the "SearchRequest" object on top of the map and json versions we have now? I could see that being useful for users who want to quickly build something out with a string.

@thlaegler
Copy link
Author

I tested with v7.3.1
Good idea with quick search. Actually, paging could also be implemented. But it looks like the paging works a bit different than the other paging-APIs so I didn't implemented it

@cdancy cdancy merged commit 0af0109 into cdancy:master Oct 27, 2020
@cdancy
Copy link
Owner

cdancy commented Oct 30, 2020

@thlaegler sorry for the delay. There were checkstyle issues when I ran locally and didn't have the time to address them until now. 2.7.1 is now released and should be good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdancy cdancy cdancy approved these changes

Assignees

@cdancy cdancy

Labels
enhancement
Projects
None yet
Milestone
v2.7.1
Development

Successfully merging this pull request may close these issues.

Feature: Search API
2 participants
@thlaegler @cdancy