Pr settings unapprove on update #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM and thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
unapproveOnUpdatetoPullRequestSettingsandCreatePullRequestSettingsin order to support getting and setting that property on repositories' PR settings.closes #262
Please do not create a Pull Request without first creating an ISSUE.
Any change needs to be discussed before proceeding.
Failure to do so may result in the rejection of the Pull Request.
Explain the details for making this change: What existing problem does the Pull Request solve? Why is this feature beneficial?
On adding new feautes/endpoints
No more than 1 endpoint should be coded within a Pull Request.
This alone requires enough code to review and adding more than 1 WILL result in your Pull Request either being ignored or rejected outright.
On adding Mock and Integ Tests
At least 2 mock tests and 2 integ tests are required prior to merging.
Each pair should should test what the success and failure of added change looks like.
More complicated additions will of course require more tests.
On CI testing (currently using travis)
Code will not be reviewed until CI passes.
Current CI does NOT exercise
integtests and so each Pull Request will have to be run manually by one of the maintainers to confirm it works as expected: please be patient.On automtatic closing of ISSUES
Put
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).