Relocating external dependencies in fat jar

[tomasbjerre]

• To avoid classpath collisions.

[cdancy]

This is fine but lets move to <project-root>/gradle/additional-artifacts.gradle where I've already stubbed out this task.

Lets do the below instead. Think that should cover all pulled in deps and give a more expected shaded naming convention.

shadowJar {
     relocate 'com.google', 'com.cdancy.bitbucket.rest.shaded.google'
     relocate 'com.squareup', 'com.cdancy.bitbucket.rest.shaded.squareup'
     relocate 'autovalue', 'com.cdancy.bitbucket.rest.shaded.autovalue'
     relocate 'javax', 'com.cdancy.bitbucket.rest.shaded.javax'
     relocate 'net', 'com.cdancy.bitbucket.rest.shaded.net'
     relocate 'okio', 'com.cdancy.bitbucket.rest.shaded.okio'
     relocate 'org', 'com.cdancy.bitbucket.rest.shaded.org'
 }

[tomasbjerre]

So se., ch. and bsh.* should not be relocated?

[cdancy]

I don't see either of those in the -all jar. Can you paste the contents of your build/libs/*-all.jar here? Perhaps they are different then mine. unzip -l *-all.jar

[tomasbjerre]

You are right =) Its not in there!

[cdancy]

Edited the code snippet above to add a shaded package to make it absolutely clear these packages are shaded.

[cdancy]

Any particular reason you removed this line or just a typo?

[tomasbjerre]

Added it again!

[cdancy]

I assume these are maven generated folders? Are you using maven somehow with this project?

[tomasbjerre]

That was probably just some files laying around. Originally generated by Eclipse. But I see Eclipse support was removed in fd13b17#diff-c197962302397baf3a4cc36463dce5ea maby you just relocate the libraries yourself?

[cdancy]

Why are we including this artifacts block? Shouldn't be necessary as we already define this within <project-root>/gradle/publishing.gradle

[tomasbjerre]

Fixed

[cdancy]

I don't mind you adding in the maven/generated dirs. Can't remember exactly why I ripped that eclipse code out initially but I remember it causing problems within my workspace.

In either event: feel free to add the generated dirs to the .gitignore if it helps.

[tomasbjerre]

Ok I'll remember it if I need something else changed in this project! But it should be ready to be merged now right?

[cdancy]

Merged. @tomasbjerre thanks for the PR!

FYI: not sure if you're looking for a new version to be put out with this change but I planned on doing another release by end of weekend. Waiting for 1 more expected PR to come in from a dev and then will release.