Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding comments action on pull requests #45

Merged
merged 1 commit into from
Mar 6, 2017
Merged

Adding comments action on pull requests #45

merged 1 commit into from
Mar 6, 2017

Conversation

tomasbjerre
Copy link
Contributor

No description provided.

@@ -5,6 +5,7 @@ bin
out
src/generated
.gradle
test-output
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I got it when running TestNG from Eclipse.

@cdancy
Copy link
Owner

cdancy commented Mar 6, 2017

Bitbucket documentation is always either hit or miss. This is one of those cases where it's a miss IMO.. Can path be null? What is it suppose to represent?

@tomasbjerre
Copy link
Contributor Author

Right, yes it should be:
https://developer.atlassian.com/static/rest/bitbucket-server/latest/bitbucket-rest.html#idm45888278617264

Path cannot be null.

I forgot to add POST, can I add that to this PR?

@cdancy
Copy link
Owner

cdancy commented Mar 6, 2017

@tomasbjerre I'll take this one but lets put POST functionality in a separate PR.

Are you able to run live tests? If so, and as part of the subsequent POST PullRequest, can you write 2 live tests: one for posting a comment and one for listing all comments? I recognize that I still have not yet made it stupid-simple to run live tests against a system so feel free to change the parameters to point at something more local to you to ensure all works as expected.

@cdancy cdancy self-assigned this Mar 6, 2017
@cdancy cdancy added this to the v0.0.14 milestone Mar 6, 2017
@cdancy cdancy merged commit a537274 into cdancy:master Mar 6, 2017
@tomasbjerre
Copy link
Contributor Author

I just noticed that POST is actually implemented! So wont be doing that.

@cdancy
Copy link
Owner

cdancy commented Mar 6, 2017

Forgot about that ;) I actually use the more simpler version which is probably why this slipped my mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants