Add possibility to delete Default Reviewers #84
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o defaultReviewers
…o defaultReviewers-list
added 19 commits
June 6, 2017 08:32
# Conflicts: # src/test/java/com/cdancy/bitbucket/rest/features/DefaultReviewersApiLiveTest.java
# Conflicts: # src/test/java/com/cdancy/bitbucket/rest/features/DefaultReviewersApiLiveTest.java
# Conflicts: # src/test/java/com/cdancy/bitbucket/rest/features/DefaultReviewersApiLiveTest.java
added 3 commits
June 6, 2017 15:13
…o defaultReviewers-update # Conflicts: # src/main/java/com/cdancy/bitbucket/rest/features/DefaultReviewersApi.java # src/test/java/com/cdancy/bitbucket/rest/BaseBitbucketApiLiveTest.java # src/test/java/com/cdancy/bitbucket/rest/features/DefaultReviewersApiLiveTest.java # src/test/java/com/cdancy/bitbucket/rest/features/DefaultReviewersApiMockTest.java
cdancy
added a commit
that referenced
this pull request
Jun 6, 2017
* First commit of default reviewers * Rename Conditions to condition * Add mock test * Add live Test * Fix build * Add more test for branchApiLiveTest * Add Fallback for Condition * Update Object Condition for add ErrorsHolder * Add rest api for create Condition * Edit MatcherId to add new value * Add live test * Add mock Test * Fix junit * Fix build * Add endpoint for Condition update * Add liveTest * Add mock Test * Fix build * Add endpoint for delete Condition * Add live Test * Fix build * Fix build * Add mock Test * Add annotation Documentation for listConditions * Add annotation Documentation for createCondition * Add annotation Documentation for updateCondition * Add annotation Documentation for deleteCondition * Add missing annotation * Fix build * Refactore test after change from master branch * Refactore test after change from master branch * fix build * Fix build * Fix build * Fix build * Edit code after codeReview from another PR (List defaultReviewers) * Fix code after codeReview * Fix issues #89 * Rename test class * Add field to get conditionId for next Step * Add live test to get listConditions * Change HardCode User to defaultUser * Fix build * Fix build * Edit code after codeReviews from another PR * Edit code after codeReviews from another PR * Edit code after codeReview * Remove test dependency don't need anymore * Edit rest named for deleteCondition * Fixes for PR-#84
|
Closing as this has been merged as part of #92 |
|
Thanks again @j0nathan33 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My last PR for next few week :)