Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null queue item task name #138

Merged
merged 2 commits into from
Jan 25, 2021
Merged

Conversation

martinda
Copy link
Collaborator

This solves Issue #136

The QueueItem contains a Task whose name can be null in some yet to be reproduced cases.

The name property of Task was made Nullable.

  • I added a mock test in the first commit.
  • I added the solution in the second commit.

I do not have an integration test because I am not able to get Jenkins to reproduce the error.

@martinda martinda requested a review from cdancy January 24, 2021 18:20
Copy link
Owner

@cdancy cdancy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdancy cdancy self-assigned this Jan 25, 2021
@cdancy cdancy added this to the v0.0.30 milestone Jan 25, 2021
@cdancy cdancy merged commit cd37c91 into cdancy:master Jan 25, 2021
@cdancy
Copy link
Owner

cdancy commented Jan 25, 2021

@martinda need a new release for this?

@martinda
Copy link
Collaborator Author

@cdancy yes please! Thank you.

@cdancy
Copy link
Owner

cdancy commented Jan 28, 2021

@martinda v0.0.28 has been released. Missed your comment otherwise I would have knocked it out sooner (takes all of about 10 seconds to do so)

@martinda martinda deleted the issue-136-null-name branch August 5, 2021 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NullPointerException in com.cdancy.jenkins.rest.domain.queue.AutoValue_Task.<init>(AutoValue_Task.java:16)
2 participants