Add optional folder path to jobs api #20
Conversation
| Plugins plugins = api.pluginManagerApi().plugins(3, null); | ||
| for(Plugin plugin:plugins.plugins()) { | ||
| if(plugin.shortName().equals(FOLDER_PLUGIN_NAME) && plugin.version().equals(FOLDER_PLUGIN_VERSION)) { | ||
| installed = true; |
There was a problem hiding this comment.
lets put a break; after this line so that we don't continue looking through the list of installed plugins which could potentially be very big.
| private Integer buildNumber; | ||
| private static final String FOLDER_PLUGIN_NAME = "cloudbees-folder"; | ||
| private static final String FOLDER_PLUGIN_VERSION = "6.4"; |
There was a problem hiding this comment.
What about using latest here instead of an actual version? That's very non-ci but I'd rather chase the latest and greatest version instead of something which may become out of date over time.
| Thread.sleep(10000); | ||
| endTime += 10000; | ||
| } | ||
| else { |
There was a problem hiding this comment.
lets put this else on the previous line.
|
@Dhivyaa21 few minor comments to address but it looks good. |
Dhivyaa21
force-pushed
the
add-optional-folder-path-to-jobsApi
branch
from
e627f0a
to
eb3a3f0
Compare
|
@cdancy - rebased the branch off of master and fixed the conflicts. Please review. |
|
@Dhivyaa21 LGTM. Thanks! @martinda pulling this into master now and doing a release shortly. Feel free to star the project and tell your friends (shameless plug) to get more folks interested and using what we're building! |
|
|
|
I added a section to advertise jenkins-rest on the Jenkins Remote access API wiki page. |
|
@martinda very awesome and a huge thank you! |
@cdancy - This is the new pull-request for issue#10. I have added an additional test method to install folder plugin(if it is not present). Please review.