Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensive build info #259

Merged
merged 2 commits into from
Sep 29, 2022
Merged

Extensive build info #259

merged 2 commits into from
Sep 29, 2022

Conversation

martinda
Copy link
Collaborator

This PR adds the ability to read _class types of build actions. Jenkins can produce build actions in the build info that look like this:

{
  "actions" : [
    {
       "text" : "Hudson, we have a problem.",
       "iconPath" : "error.svg",
       "_class" : "com.jenkinsci.plugins.badge.action.BadgeSummaryAction"
    },
    {
       "_class" : "org.jenkinsci.plugins.displayurlapi.actions.RunDisplayAction"
    }
    ]
}

These are created by pipeline code such as:

createSummary("error.svg").appendText("Hudson, we have a problem.", false, false, false, "red")

With this PR, we can read these build actions in the BuildInfo.

@martinda
Copy link
Collaborator Author

I added mock and integration tests, they all pass using the docker container. I had to upgrade Jenkins so it could support an easy way to add build actions.

Copy link
Owner

@cdancy cdancy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @martinda feel free to merge when you're ready.

@martinda martinda merged commit 0c3fb6c into cdancy:master Sep 29, 2022
@martinda
Copy link
Collaborator Author

@cdancy a new release would be much appreciated. Thanks!

@cdancy
Copy link
Owner

cdancy commented Sep 29, 2022

@martinda just released version 1.0.2. I'd give it a bit but it should be resolvable soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants