Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CDAP-14912] Make noSql metadata storage independent of dataset framework #11062

Merged
merged 1 commit into from Feb 15, 2019

Conversation

anew
Copy link
Contributor

@anew anew commented Feb 13, 2019

This removes a cyclic dependency that would (due to the way guice injection is done) prevent proper injection. With a dependency on dataset framework, which itself depends on metadata. This should fix that.

@anew anew added the On-hold label Feb 13, 2019
@anew anew force-pushed the feature/CDAP-14912-metads-no-ds-framework branch from dc7ed76 to 0cfe074 Compare February 13, 2019 19:14
@anew
Copy link
Contributor Author

anew commented Feb 13, 2019

@anew anew added 6.0 and removed On-hold labels Feb 13, 2019
@anew anew force-pushed the feature/CDAP-14912-metads-no-ds-framework branch from 0cfe074 to 152720a Compare February 13, 2019 19:34
@anew
Copy link
Contributor Author

anew commented Feb 13, 2019

rebased on latest develop

@anew anew force-pushed the feature/CDAP-14912-metads-no-ds-framework branch from 152720a to b4a3c01 Compare February 14, 2019 01:24
Copy link
Contributor

@albertshau albertshau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anew anew force-pushed the feature/CDAP-14912-metads-no-ds-framework branch from b4a3c01 to dda6297 Compare February 15, 2019 00:07
@anew anew force-pushed the feature/CDAP-14912-metads-no-ds-framework branch from dda6297 to 2bf64b5 Compare February 15, 2019 00:13
@anew
Copy link
Contributor Author

anew commented Feb 15, 2019

All builds passed. Rebased on latest develop, updated copyrights and squashed. Merging.

@anew anew merged commit 0bc6ddd into develop Feb 15, 2019
@fernst fernst deleted the feature/CDAP-14912-metads-no-ds-framework branch February 25, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants