CDAP-16709 implement manual broadcasts #12213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertshau
force-pushed
the
feature_release/CDAP-16709-manual-broadcast
branch
from
54dfff9
to
e5a66dc
Compare
yaojiefeng
approved these changes
May 28, 2020
| @@ -95,6 +95,9 @@ public void initialize() throws Exception { | |||
|
|
|||
| SparkConf sparkConf = new SparkConf(); | |||
| sparkConf.set("spark.speculation", "false"); | |||
| // turn off auto-broadcast by default until we better understand the implications and can set this to a | |||
| // value that we are confident is safe. | |||
| sparkConf.set("spark.sql.autoBroadcastJoinThreshold", "-1"); | |||
There was a problem hiding this comment.
Is there any constant class we can use for these config?
There was a problem hiding this comment.
not that I know of. If there was, it could potentially change across different Spark versions too.
albertshau
force-pushed
the
feature_release/CDAP-16709-manual-broadcast
branch
from
e5a66dc
to
9064e40
Compare
Honor the broadcast flag set in the JoinDefinition when joining multiple DataFrames. Added a small tweak to the join logic to join all non-broadcasted datasets first in order to ensure that both sides of the join are not broadcast, and to reduce the amount of data that is being shuffled in non-broadcast intermediate joins.
albertshau
force-pushed
the
feature_release/CDAP-16709-manual-broadcast
branch
from
9064e40
to
65d9edc
Compare
chtyim
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honor the broadcast flag set in the JoinDefinition when joining
multiple DataFrames. Added a small tweak to the join logic to
join all non-broadcasted datasets first in order to ensure that
both sides of the join are not broadcast, and to reduce the amount
of data that is being shuffled in non-broadcast intermediate joins.