(CDAP-17287) Collects Spark execution event logs #12782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dli357
reviewed
Sep 23, 2020
| throw new UnsupportedOperationException("Spark event logs collection is not enabled"); | ||
| } | ||
|
|
||
| if (!"application/octet-stream".equals(request.headers().get(HttpHeaderNames.CONTENT_TYPE))) { |
There was a problem hiding this comment.
Maybe we can use javax.ws.rs.core.MediaType.APPLICATION_OCTET_STREAM?
cdap-spark-core-base/src/main/java/io/cdap/cdap/app/runtime/spark/SparkRuntimeUtils.java
Outdated
Show resolved
Hide resolved
cdap-spark-core-base/src/main/java/io/cdap/cdap/app/runtime/spark/SparkRuntimeUtils.java
Show resolved
Hide resolved
| HttpURLConnection urlConn = remoteClient.openConnection(HttpMethod.POST, path); | ||
| try { | ||
| urlConn.setChunkedStreamingMode(CHUNK_SIZE); | ||
| urlConn.setRequestProperty(HttpHeaders.CONTENT_TYPE, "application/octet-stream"); |
There was a problem hiding this comment.
Maybe we can use javax.ws.rs.core.MediaType.APPLICATION_OCTET_STREAM?
cdap-spark-core-base/src/main/java/io/cdap/cdap/app/runtime/spark/SparkRuntimeUtils.java
Outdated
Show resolved
Hide resolved
cdap-spark-core-base/src/main/java/io/cdap/cdap/app/runtime/spark/SparkRuntimeUtils.java
Outdated
Show resolved
Hide resolved
dli357
approved these changes
Sep 23, 2020
cdap-spark-core-base/src/main/java/io/cdap/cdap/app/runtime/spark/SparkRuntimeUtils.java
Outdated
Show resolved
Hide resolved
chtyim
force-pushed
the
feature/CDAP-17287-collect-spark-history
branch
2 times, most recently
from
0277c88
to
83144b4
Compare
- Introducing the Spark event logging and upload of logs through the runtime service. Based on the cConf settings, the event logging collection will be on/off regardless of the Spark job spark.eventLog.* configurations. - Refactoring of the SparkRuntimeEnv class to simplify the logic by using CompletableFuture. - Make runtime system services shutdown after the SparkExecutionContext stopped. Currently they stop concurrently. It is not a problem before this PR since we are not doing any important work at the context stop. However, this PR introduces uploading the event logs at the context stop, which needs to be completed before the system services shutdown and process termination.
chtyim
force-pushed
the
feature/CDAP-17287-collect-spark-history
branch
from
83144b4
to
63aa9a7
Compare
|
Build passed https://builds.cask.co/browse/CDAP-DUT7352-7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has three commits:
SparkExecutionContextstopped. Currently they stop concurrently. It is not a problem before this PR since we are not doing any important work at the context stop. However, this PR introduces uploading the event logs at the context stop, which needs to be completed before the system services shutdown and process termination.SparkRuntimeEnvclass to simplify the logic.spark.eventLog.*configurations.