Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permission model clean-up #13455

Merged
merged 1 commit into from
Jun 18, 2021
Merged

Permission model clean-up #13455

merged 1 commit into from
Jun 18, 2021

Conversation

tivv
Copy link
Contributor

@tivv tivv commented Jun 9, 2021 •
edited
Loading

Clean up final usage of the old permission model & remove obsolete classes that were used internally during the migration

@gitpod-io
Copy link

gitpod-io bot commented Jun 9, 2021

@google-cla google-cla bot added the cla: yes label Jun 9, 2021
@tivv tivv added build Triggers github actions build and removed cla: yes labels Jun 9, 2021
@google-cla google-cla bot added the cla: yes label Jun 9, 2021
@tivv tivv force-pushed the feature/full_permission_model_2 branch 2 times, most recently from aaa603e to bde4beb Compare June 9, 2021 16:00
@tivv tivv mentioned this pull request Jun 9, 2021
Open
@tivv tivv force-pushed the feature/full_permission_model_2 branch 2 times, most recently from 9dce629 to 2ed23b7 Compare June 10, 2021 17:19
@tivv tivv added build Triggers github actions build and removed build Triggers github actions build labels Jun 10, 2021
@tivv tivv force-pushed the feature/full_permission_model_2 branch from 2ed23b7 to 133c91f Compare June 14, 2021 23:27
@tivv tivv added build Triggers github actions build and removed build Triggers github actions build labels Jun 15, 2021
@tivv tivv force-pushed the feature/full_permission_model_2 branch from 133c91f to b429134 Compare June 15, 2021 17:49
@tivv tivv added build Triggers github actions build and removed build Triggers github actions build labels Jun 15, 2021
@tivv tivv force-pushed the feature/full_permission_model_2 branch from b429134 to 26b78dd Compare June 15, 2021 21:48
@tivv
Clean up final usage of the old permission model & remove obsolete cl…
0c4d6d7 
…asses that were used internally during the migration
@tivv tivv force-pushed the feature/full_permission_model_2 branch from 26b78dd to 0c4d6d7 Compare June 17, 2021 19:05
@tivv tivv added build Triggers github actions build and removed build Triggers github actions build labels Jun 17, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jun 17, 2021

SonarCloud Quality Gate failed.

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 98 Code Smells

25.1% 25.1% Coverage
1.6% 1.6% Duplication

@tivv tivv marked this pull request as ready for review June 18, 2021 02:07
@tivv tivv merged commit 2388905 into develop Jun 18, 2021
@tivv tivv deleted the feature/full_permission_model_2 branch June 18, 2021 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyzhang wyzhang wyzhang approved these changes

@dli357 dli357 Awaiting requested review from dli357

@greeshmaswaminathan greeshmaswaminathan Awaiting requested review from greeshmaswaminathan

@albertshau albertshau Awaiting requested review from albertshau

@chtyim chtyim Awaiting requested review from chtyim

@CuriousVini CuriousVini Awaiting requested review from CuriousVini

@fernst fernst Awaiting requested review from fernst

Assignees
No one assigned
Labels
build Triggers github actions build cla: yes
Projects
None yet
Milestone
No milestone
2 participants
@tivv @wyzhang