Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TESTING.md #356

Merged
merged 1 commit into from Dec 5, 2017
Merged

Add TESTING.md #356

merged 1 commit into from Dec 5, 2017

Conversation

wolf31o2
Copy link
Contributor

@wolf31o2 wolf31o2 commented Dec 5, 2017

Signed-off-by: Chris Gianelloni wolf31o2@gmail.com

Copy link
Contributor

@dereklwood dereklwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one bad link, otherwise lgtm

TESTING.md Outdated
@@ -0,0 +1,44 @@
This cookbook uses a variety of testing components:

- Unit tests: [ChefSpec](http://code.sethvargo.com/chefspec/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

broken link.... probably want https://docs.chef.io/chefspec.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I get for copying the file from another repo and just replacing the org/repo names.

TESTING.md Outdated

7. Assuming the tests pass, open a Pull Request on GitHub

For more information, see [the cookbooks Contribution Guidelines](https://github.com/caskdata/hadoop_cookbook/blob/master/CONTRIBUTING.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cookbook's

Signed-off-by: Chris Gianelloni <wolf31o2@gmail.com>
@wolf31o2 wolf31o2 merged commit f3c7cf7 into master Dec 5, 2017
@wolf31o2 wolf31o2 deleted the feature/testing-md branch December 5, 2017 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants