Find appropriate URL for given forge version #25
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URL for the Forge download is currently assumed to be in the form of
'.../forge/%s/forge-%s-installer.jar' % (forge_fullver, forge_fullver)
, but upon inspecting various versions, there is a greater variety. e.gMinecraft 1.7.10, Forge 10.13.4.1614:
.../forge/1.7.10-10.13.4.1614-1.7.10/forge-1.7.10-10.13.4.1614-1.7.10-installer.jar
Minecraft 1.7.10, Forge 10.13.3.1395:
.../forge/1.7.10-10.13.3.1395-1710ls/forge-1.7.10-10.13.3.1395-1710ls-installer.jar
A function
get_forge_url()
was implemented to obtain the required download URL by scraping the Forge download page for the specified Minecraft version, and using a regex to find the appropriate URL for the specified Forge version.The following shows its use:
This resolves the issue noted in #16.