Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added mask for lens distortion in images #968

Merged
merged 11 commits into from
May 4, 2023

Conversation

PxGluz
Copy link

@PxGluz PxGluz commented Apr 7, 2023

This PR adds a mask that accounts for the lens distortion and filters what is shown on the texture. Solves issue #961

Copy link
Owner

@cdcseacave cdcseacave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, pls see comments

libs/MVS/SceneTexture.cpp Outdated Show resolved Hide resolved
libs/MVS/SceneTexture.cpp Outdated Show resolved Hide resolved
libs/MVS/SceneTexture.cpp Outdated Show resolved Hide resolved
libs/MVS/SceneTexture.cpp Outdated Show resolved Hide resolved
libs/MVS/SceneTexture.cpp Outdated Show resolved Hide resolved
libs/MVS/SceneTexture.cpp Outdated Show resolved Hide resolved
libs/MVS/SceneTexture.cpp Outdated Show resolved Hide resolved
libs/MVS/SceneTexture.cpp Outdated Show resolved Hide resolved
libs/MVS/SceneTexture.cpp Outdated Show resolved Hide resolved
Copy link
Owner

@cdcseacave cdcseacave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now, thx

libs/MVS/SceneTexture.cpp Outdated Show resolved Hide resolved
libs/MVS/SceneTexture.cpp Outdated Show resolved Hide resolved
libs/MVS/SceneTexture.cpp Outdated Show resolved Hide resolved
libs/MVS/SceneTexture.cpp Outdated Show resolved Hide resolved
libs/MVS/SceneTexture.cpp Outdated Show resolved Hide resolved
libs/MVS/SceneTexture.cpp Outdated Show resolved Hide resolved
libs/MVS/SceneTexture.cpp Outdated Show resolved Hide resolved
libs/MVS/SceneTexture.cpp Outdated Show resolved Hide resolved
libs/MVS/SceneTexture.cpp Outdated Show resolved Hide resolved
libs/MVS/SceneTexture.cpp Outdated Show resolved Hide resolved
libs/MVS/SceneTexture.cpp Outdated Show resolved Hide resolved
libs/MVS/SceneTexture.cpp Outdated Show resolved Hide resolved
libs/MVS/SceneTexture.cpp Outdated Show resolved Hide resolved
libs/MVS/SceneTexture.cpp Outdated Show resolved Hide resolved
libs/MVS/SceneTexture.cpp Outdated Show resolved Hide resolved
libs/MVS/SceneTexture.cpp Outdated Show resolved Hide resolved
libs/MVS/SceneTexture.cpp Outdated Show resolved Hide resolved
libs/MVS/SceneTexture.cpp Outdated Show resolved Hide resolved
@apurvazaveri
Copy link

Any idea when this shall be approved? I can do some testing of this feature.

@cdcseacave cdcseacave merged commit b41a8ce into cdcseacave:develop May 4, 2023
0 of 3 checks passed
@cdcseacave
Copy link
Owner

@apurvazaveri sry for the long delay, it is merged now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants