Add support for skipping or expecting failure on a test #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed because during the test writing process there are often _many_ things that ought to succeed but don't that are beyond the scope of the immediate project. For example a framework not properly returning a 405 when a method is not allowed, or returning 405 but then not returning the Allow header. This feature required switching the base test case from unittest to testtools. The former has changed (in Python 3.4) the internals of how expecting failure is handled and as a result making it work with dynamically generated tests was proving extremely difficult. An additional shell driven test is provided for coverage of skip and fail.
|
@FND if you've got a moment a sanity check on this would be helpful, but no worries if not. |
| @@ -13,23 +13,40 @@ | |||
| # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | |||
| # License for the specific language governing permissions and limitations | |||
| # under the License. | |||
| """A single HTTP request reprensented as a ``unittest.TestCase`` | |||
| """A single HTTP request reprensented as a subclass of ``unittest.TestCase`` | |||
|
seems sensible to me - though of course I lack familiarity to provide a truly informed assessment (I was confused when yesterday I said "shouldn't the testing framework be responsible for this"; I was thinking of |
cdent
added a commit
that referenced
this pull request
Feb 11, 2015
Add support for skipping or expecting failure on a test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed because during the test writing process there
are often many things that ought to succeed but don't that are
beyond the scope of the immediate project. For example a framework
not properly returning a 405 when a method is not allowed, or
returning 405 but then not returning the Allow header.
This feature required switching the base test case from unittest to
testtools. The former has changed (in Python 3.4) the internals of how
expecting failure is handled and as a result making it work with
dynamically generated tests was proving extremely difficult.
An additional shell driven test is provided for coverage of
skip and fail.