Drop support for py2 and remove testtools #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial motivation for this change was removing the testtools library. It has a cyclical dependency with the fixutures module which makes installing gabbi in some environments (notably bazel) difficult. Please to fix this problem in the testtools and fixtures communities have gone unaddressed for _years_ so an effort was undertaken to remove them. That work exposed that much of what testtools was doing was masking over differences in python3 and python3 unittests. Since it is 2020, choosing to drop support for python2 is a legitimate choice. People who still need support for python2 can use an earlier version of gabbi. To signal that change, the version number has been raised to 2.0.0. tox, travis config and setup.cfg have been updated accordingly.
pypy3 is considered "supported" by travis now, so we don't need a specific dist, and the location of placement master has moved. Fix to the new location and add -L to the curl to save us if there are future changes.
FND
reviewed
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial motivation for this change was removing the testtools
library. It has a cyclical dependency with the fixutures module
which makes installing gabbi in some environments (notably bazel)
difficult. Please to fix this problem in the testtools and fixtures
communities have gone unaddressed for years so an effort was
undertaken to remove them.
That work exposed that much of what testtools was doing was masking
over differences in python3 and python3 unittests. Since it is 2020,
choosing to drop support for python2 is a legitimate choice. People
who still need support for python2 can use an earlier version of
gabbi.
To signal that change, the version number has been raised to 2.0.0.
tox, travis config and setup.cfg have been updated accordingly.