added support for custom response handlers to gabbi-run #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with extensive assistance from @cdent
this should make debugging a little less painful oddly, this only seems to work for STDERR - @cdent?
because why not
before:
gabbi-run -r my_response_handler:MyResponseHandler
after:
gabbi-run -r my_response_handler
the latter is *much* more convenient
not sure where to document the contract though: the given module is
expected to contain a `gabbi_response_handlers` object, which is either
a sequence of response handler classes or a function returning such a
sequence
/cc @cdent
By default testr will swallow output to STDOUT so if we want to make output of gabbi-run visible when there are unexpected errors from runner.run() we need to send it to STDERR. (For those inclined this change can be tested by changing a test in test_runner to fail and then `tox -epy34 -- test_runner`.)
not exactly sure what this means, but @cdent suggests these should be linked now
|
@jasonamyers if you get a chance to glance at this that would be awesome but no biggie if not, @FND and I are both happy with it. |
|
I like the idea and the test pass so 👍 |
cdent
added a commit
that referenced
this pull request
Oct 1, 2015
added support for custom response handlers to gabbi-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the CLI option should be self-explanatory - we'll probably need a little more guidance for extension authors eventually, but for now the referenced function's docstring should suffice