Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement /delete handler #34

Closed
cdent opened this issue Feb 9, 2014 · 4 comments
Closed

Implement /delete handler #34

cdent opened this issue Feb 9, 2014 · 4 comments
Milestone

Comments

@cdent
Copy link
Owner

cdent commented Feb 9, 2014

There's template code that wants a POST-able /delete handler. Could be used for all of tiddlers, tanks and comps, based on args.

Why not use JavaScript and the API? Maybe it should, but much of the system thus far works without it.

@cdent cdent added this to the beta-f2 milestone Feb 25, 2014
@cdent
Copy link
Owner Author

cdent commented Feb 25, 2014

I still can't decide how best to implement delete. This is a question about UI and UX, not behind the scenes (that part is easy).

  • Do we want to enable delete of a page on the actual page? If not there, where? An admin page?
  • Should the /dash expose tank and comp deletion furniture, or should that go on an admin page akin to policymgr?

The answers to these questions say something about the level of casualness that should be associated with delete. Should it be an action that is to-hand, or should it take some effort?

/cc @pads, @jsavage, @FND

@jsavage
Copy link

jsavage commented Feb 26, 2014

I think this needs to be considered alongside rename. I can also envisage
copy being a useful feature where you know that a bunch of tiddlers are
going to be based on a template that you could copy and then (separately)
rename.
I would have thought that a trash icon to the right of the owner's name
might be a good start. Deleting a non-empty tiddler should require more
than one click though.

I would have thought that /Dash would only need to have facilities for
managing Tanks and that managing tiddlers could then happen at the Tank Top
Level. However we will need to be careful of dependencies from other tanks.

Finally, I suspect we will need a "list all tiddlers" button in each Tank
top to manage orphans and binaries within that tank. An icon or tooltip to
indicate dependencies / identify orphans would be potentially useful here.

On 25 February 2014 23:42, Chris Dent notifications@github.com wrote:

I still can't decide how best to implement delete. This is a question
about UI and UX, not behind the scenes (that part is easy).

  • Do we want to enable delete of a page on the actual page? If not
    there, where? An admin page?
  • Should the /dash expose tank and comp deletion furniture, or should
    that go on an admin page akin to policymgr?

The answers to these questions say something about the level of casualness
that should be associated with delete. Should it be an action that is
to-hand, or should it take some effort?

/cc @pads https://github.com/pads, @jsavage https://github.com/jsavage,
@FND https://github.com/FND

Reply to this email directly or view it on GitHubhttps://github.com//issues/34#issuecomment-36073528
.

My status

Get Skype and call me
for free.

@cdent
Copy link
Owner Author

cdent commented Mar 1, 2014

added trash can to pages: e51742a

tanks next

@cdent
Copy link
Owner Author

cdent commented Mar 1, 2014

tank delete: 4b8d22e

@cdent cdent closed this as completed Mar 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants