Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validating Passwords #26

Merged
merged 40 commits into from
Nov 29, 2020
Merged

Validating Passwords #26

merged 40 commits into from
Nov 29, 2020

Conversation

Vlix
Copy link
Collaborator

@Vlix Vlix commented Oct 18, 2020 •
edited
Loading

This is a new PR using the progress that @HirotoShioi made in the previous PR (#21) but kept in this repo, to adjust before merging into the master branch.

Original PR message

This PR introduces Validate module which exposes set of functions that can be used to validate Password with given PasswordPolicy.

HirotoShioi and others added 19 commits May 18, 2020 15:29
@HirotoShioi
Add module for validating password
f0d45bc
@HirotoShioi
Change the structure of PasswordPolicy
f026e17
@HirotoShioi
Add maximum password length policy
f1a1973
@HirotoShioi
Add test for valid password
d201fb9
@HirotoShioi
Add test for validating invalid password
f549594
@HirotoShioi
Add haddock comments
8d0b68a
@HirotoShioi
Move Arbitrary instances to test module
222a910
@HirotoShioi
Rename PasswordPolicy field, valid
3dcd375
@HirotoShioi
Use RecordWildCards, add backlash as special character
0052887
@HirotoShioi
Add test for defaultCharacterSet
c798d0d
@HirotoShioi
Remove charSet field from PasswordPolicy, introduce CharSetPredicate
7648672
@HirotoShioi
Apply changes based upon the comments
1c2bcef
@HirotoShioi
Add function validateCharSetPredicate, introduce more test cases
dc62c96
@HirotoShioi
Remove maybe, edit haddock comments
d96c6c9
@HirotoShioi
Introduce InvalidPolicyReason
f8da36c
@Vlix
Some code adjustments. DRY-er and 'ValidationResult' hopefully makes …
185d340 
…for a nicer API
@Vlix
Added @SInCE footers and made some tweaks to comments/documentation
9023ca0
@Vlix
small fix
337590b
@Vlix
adjusted tests for new structure and added some unit tests
dbd609b
@Vlix Vlix mentioned this pull request Oct 18, 2020
Closed
@Vlix Vlix self-assigned this Oct 18, 2020
@Vlix Vlix added the enhancement New feature or request label Oct 18, 2020
Vlix and others added 13 commits November 1, 2020 23:23
@Vlix
some more comment adjustments
ac98884
@Vlix
upped version in 'password.cabal'
e31e215
@Vlix
changed 'unValidatePasswordPolicy' to 'fromValidPasswordPolicy' and a…
2a8709d 
…dded Ord instance and documentation to 'ValidPasswordPolicy
@Vlix
added enough documentation for a new user to get an idea in how to us…
a3c16dd 
…e this API
@Vlix
added hie.yaml and linted a bit with HLS
4d7bc67
@Vlix
thought of a different way a policy can be invalid (CategoryAmountsAb…
e11a0af 
…oveMaxLength)
@Vlix
added 'testPolicy' for a TH consistency check
349b520
@Vlix
added 'validatePasswordPolicyTH' to get 'ValidPasswordPolicy's at com…
42d63dd 
…pile time, with a caveat (can't set 'charSetPredicate')
@Vlix
added 'CategoryAmountAboveMaxLength' to tests and added TemplateHaske…
d088030 
…ll tests to guarantee consistency
@Vlix
update ALL the documentation (and export allButCSP for tests)
b6f3df5
@Vlix
added an extra regression test to make sure testPolicy isn't compromised
f2f89bf
@Vlix
updated Changelog to indicate I worked on this too
434af82
@Vlix
Merge pull request #27 from Vlix/validate-password
1651af1 
Some additions / modifications to password validation
@Vlix
Copy link
Collaborator Author

Vlix commented Nov 29, 2020

I had a last skim over the documentation and code, and it looks fine. I think we can just merge this and release password-2.1.0.0.

@Vlix Vlix merged commit 50ff093 into master Nov 29, 2020
@cdepillabout cdepillabout deleted the validate-password branch November 30, 2020 00:09
@cdepillabout
Copy link
Owner

@Vlix Thanks for finishing this up and pushing it through!

I saw you made a release here on GitHub, but it looks like maybe you haven't uploaded it to Hackage yet? Did you want me to do this?

@Vlix
Copy link
Collaborator Author

Vlix commented Dec 1, 2020 •
edited
Loading

Uhmmm, not sure why I didn't. Slipped my mind, I guess.
If it's not too much hassle, please do upload it. Dunno if we want to make a Reddit announcement or something?

Also, I heard something was happening with Travis-ci.org, or something? Do we want to move away from that as well?

@Vlix
Copy link
Collaborator Author

Vlix commented Dec 8, 2020

@cdepillabout I've uploaded 2.1.0.0 and made a post here on reddit

@cdepillabout
Copy link
Owner

@Vlix Thanks for uploading it and sending the post on reddit. It seemed like it went over really well!

I create a branch for switching to github actions. I'll probably try to get this working in the next couple of days: #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Vlix Vlix

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Vlix @cdepillabout @HirotoShioi