Argon2 v10 fix #56
Merged
Argon2 v10 fix #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es to version 1.0
…ike they were version 1.0
|
Just remembered it might be a good idea to also mention this in the documentation of |
|
Sorry for taking a long time to respond to this. I hope to get to this in a few days. |
|
No rush, this isn't a pressing fix 👌 |
cdepillabout
reviewed
Mar 4, 2022
password/src/Data/Password/Argon2.hs
Outdated
| let ps = T.split (== ',') params | ||
| guard $ Prelude.length ps == 3 | ||
| go ps (Nothing, Nothing, Nothing) | ||
| parseAll argon2Variant argon2Version parametersT salt64 hashedKey64 = do |
There was a problem hiding this comment.
Just a nitpick, but I felt like I wanted a type signature on this function. I thought it might be a little easier to see exactly what it is doing.
There was a problem hiding this comment.
parseAll :: Argon2.Variant -> Argon2.Version -> Text -> Text -> Text -> Maybe (Argon2Params, Salt Argon2, ByteString)Sure, I'll add this in before I merge it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to fix #54
Argon2 hash without a version part will be interpreted as having been hashed with version 1.0 (
v=16)Not so much a "bug", especially since almost all usages of Argon2 are generally version 1.3, but it's a small effort to also accept hashes without a version part.