New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce CLI (#14) #70
Conversation
This seems like a reasonable CLI tool to provide. I think the README, CHANGELOG, etc, still need to be cleaned up, but the general direction seem reasonable. @Vlix any objection to providing a tool like this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments if we decide we want this CLI tool.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I've left a few comments with some questions and/or suggestions, but at first glance it seems fine as a first MVP. (If we want to provide a useful, secure CLI, this will definitely take many many additions and tweaks in the coming years 😅 )
This is actually one of the issues that we have open right now #14 😄 @blackheaven Thank you for the effort of setting this up 👍 |
I'd also like to see some tests for the CLI to make sure it functions as expected. |
updated, let me know what you think |
One of the problems with this is that I don't necessarily think we shouldn't add tests like this, but let's make it either disabled by default, or add a flag to the |
I've tested a bit, and would indeed like to have the And a few more requests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's beginning to look pretty good.
Thanks for all the effort 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cdepillabout Do you want to take one more look and check if anything essential is missing? Or anything unsafe / unsecure?
I'm probably going to add more documentation and extend the README after this is merged in, and maybe add some extra options while I'm at it.
Before publishing, we probably want to make the CLI a bit more feature complete, but this is a solid start, methinks, and this PR can at least be merged into the main code base.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this!
No description provided.