Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

password: small tweak to 'Bcrypt.extractParams' #80

Merged
merged 4 commits into from
Jul 6, 2024
Merged

password: small tweak to 'Bcrypt.extractParams' #80

merged 4 commits into from
Jul 6, 2024

Conversation

Vlix
Copy link
Collaborator

@Vlix Vlix commented May 25, 2024

Fixing #66

@Vlix Vlix requested a review from cdepillabout May 25, 2024 22:59
cdepillabout
cdepillabout approved these changes May 28, 2024
View reviewed changes
Copy link
Owner

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although you might want to leave a comment right about the changed lines about why it is now written like this (just so someone doesn't come along and refactor it back)

@Vlix Vlix force-pushed the tweak-bcrypt-extractParams branch from 1794fc3 to 73ab891 Compare June 8, 2024 18:55
@Vlix Vlix merged commit db4cd2e into cdepillabout:master Jul 6, 2024
15 of 17 checks passed
@Vlix Vlix deleted the tweak-bcrypt-extractParams branch July 6, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Vlix @cdepillabout