Java SDK tests against examples from the spec repo #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-est
reviewed
Dec 20, 2023
| @@ -1,22 +1,42 @@ | |||
| package dev.cdevents.constants; | |||
|
|
|||
| import dev.cdevents.events.*; | |||
There was a problem hiding this comment.
Does this pass linting?
Maybe a comment on why the import ...* i.e we need all the events
There was a problem hiding this comment.
Linting doesn't stop this
afrittoli
reviewed
Jan 10, 2024
Comment on lines
+37
to
+41
| createdEvent.setSource(URI.create("/event/source/123")); | ||
| createdEvent.setSubjectId("pkg:golang/mygit.com/myorg/myapp@234fd47e07d1004f0aed9c"); | ||
| createdEvent.setSubjectSource(URI.create("/event/source/123")); | ||
| createdEvent.setSubjectChangeId("myChange123"); | ||
| createdEvent.setSubjectChangeSource("my-git.example/an-org/a-repo"); |
There was a problem hiding this comment.
Except for this section, these tests can also be generated or generalised eventually
There was a problem hiding this comment.
Will do a refactor of these tests in a separate PR
rjalander
force-pushed
the
SDK_Test_Examples
branch
3 times, most recently
from
cf1a64c
to
ef4aeeb
Compare
update unit testing for new events add unit testing for CDEventClass generated for each schema file Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech>
Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech>
Signed-off-by: Jalander Ramagiri <jalander.ramagiri@est.tech>
rjalander
force-pushed
the
SDK_Test_Examples
branch
from
ef4aeeb
to
f7f24f4
Compare
afrittoli
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the changes to,