Enforce the source format URI-reference via the jsonschema #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The format of the source field is defined as URI-reference https://github.com/cdevents/spec/blob/v0.1.1/spec.md#source-context This is consistent with the CloudEvents specification. It reflects the fact that not every source will be an URL. If later on we decide on a more specific format, we can enforce it then. Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
afrittoli
force-pushed
the
issues/114-uri-reference
branch
from
f8f2cfe
to
d05f226
Compare
|
I believe this PR should be seen as the solution to #114 |
Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
e-backmark-ericsson
approved these changes
Mar 10, 2023
This was referenced Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The format of the source field is defined as URI-reference https://github.com/cdevents/spec/blob/v0.1.1/spec.md#source-context
This is consistent with the CloudEvents specification. It reflects the fact that not every source will be an URL.
If later on, we decide on a more specific format, we can enforce it then.
Submitter Checklist
As the author of this PR, please check off the items in this checklist: