Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for release v0.2.0 #120

Merged
merged 2 commits into from
Mar 20, 2023
Merged

Conversation

afrittoli
Copy link
Contributor

@afrittoli afrittoli commented Mar 16, 2023

Changes

Release incident events to 0.1.0.
Release the spec to 0.2.0.
Update schemas, examples and markdown to the new versions.
Extend the release script to handle example files too.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release incident events to 0.1.0.
Release the spec to 0.2.0.
Update schemas, examples and markdown to the new versions.
Extend the release script to handle example files too.

Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
@afrittoli afrittoli mentioned this pull request Mar 16, 2023
11 tasks
Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>

# Evaluate the event version
OLD_VERSION=$(sed -n -e '/"default": "dev.cdevents.'${SUBJECT}'.'${PREDICATE}'./s/.*\.\([0-9]\.[0-9]\.[0-9]\)"/\1/p' ${SCHEMA_FILE})
OLD_VERSION=$(sed -n -e '/"default": "dev.cdevents.'${SUBJECT}'.'${PREDICATE}'./s/.*\.\([0-9]\.[0-9]\.[0-9]\(-draft\)\{0,1\}\)"/\1/p' ${SCHEMA_FILE})

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still learning about release cadence and pattern for the project so my understanding is likely wrong, if you are removing the reference -draft from schemas then should it be included in the regex?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review!
The regex allows for the -draft to both be and not be there.
When we start working on a new release, we set it with the -draft, when we cut a release, we remove it.
See https://cdevents.dev/docs/primer/#development-of-a-new-version
This script is a helper to start and finish releases, and it must be able to parse the current version in both cases.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes perfect sense!

@afrittoli afrittoli merged commit acc3864 into cdevents:main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants