Fix custom schema and add validation #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will fail validation until #205 is merged |
The custom schema had a few issues to be fixed: - missing chainId and links from the context - missing version in the type regex - replace "." with "\." in the type regex This PR fixes all those and adds a conformance.json example file to validate against the custom schema. Fixes cdevents#216 Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
afrittoli
force-pushed
the
fix_custom_schema
branch
from
fca7487
to
6f7996a
Compare
xibz
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The custom schema had a few issues to be fixed:
This PR fixes all those and adds a conformance.json example file to validate against the custom schema.
Fixes #216
Submitter Checklist
As the author of this PR, please check off the items in this checklist: