-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add versioning details to spec and primer #67
Conversation
Add details about the specification versioning, the event versioning and the schemas. Update the spec version to 0.1.0-draft as starting in-progress version. Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
I miss some reasoning in the proposed versioning section in the primer about why the individual event versions don't need to include the patch level on their semantic versions. Is there such a reasoning that could be documented? As a reference, in Eiffel we do use version stepping on patch level, when for example a valid list of characters for a string value in an event is decreased, as can be seen in this document: https://github.com/eiffel-community/eiffel/blob/master/eiffel-syntax-and-usage/versioning.md#rules-for-patch-minor-and-major-versions Maybe that is unnecessarily complex and we could use minor version stepping in such cases as well, but I believe some kind of reasoning would be valuable to provide in the primer for that. |
Oh, interesting, I didn't include patch level because I didn't see a use case for that, but even if that were true it is still worth commenting about it in the spec as you mentioned. I imagined patch level would be used for things like addressing security issues which need to be back-ported, fixing regression issues, and at first sight it didn't seem applicable to events, but perhaps it is. |
Thanks for sharing the Eiffel docs about this @e-backmark-ericsson. Looking at the description of "patch":
The example provided seems like a backward incompatible change to me, as existing valid producers might stop working. |
Update from the chat on slack, from Emil
|
@e-backmark-ericsson Updated based on your feedback - I added the patch version for events. |
Based on the discussion on the PR and slack, adding the patch version for events as well. Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor (patch) correction needed.
Co-authored-by: Emil Bäckmark <emil.backmark@ericsson.com>
Add details about the specification versioning, the
event versioning and the schemas. Update the spec version
to 0.1.0-draft as starting in-progress version.
Update vocabulary and examples
Fixes #43
Signed-off-by: Andrea Frittoli andrea.frittoli@gmail.com