Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Looser interpretation of tags. #182

Closed
bryce-admin opened this issue Oct 26, 2016 · 4 comments
Closed

Feature request: Looser interpretation of tags. #182

bryce-admin opened this issue Oct 26, 2016 · 4 comments

Comments

@bryce-admin
Copy link

I've noticed that using freeform tags ("This is #sometag, this is #anothertag, and this is me embedding a #tag at the end.") has a subtle problem. The problem occurs when the user clicks on a tag with some punctuation immediately following it (e.g., "#sometag") Unmark returns the "The URI you submitted has disallowed characters" error.

Would it be feasible to loosen interpretation of tags to ignore commas, semicolons, colons, and suchlike? That would make it easier to use tags in a freeform manner (embedded in notes and text).

@cdevroe
Copy link
Owner

cdevroe commented Oct 28, 2016

@bryce-admin I like where this is going. However, in the 1.8.x line of Unmark we'll be introducing a dedicated "tags" input area that will work much more like a traditional tag input like you see elsewhere. So this issue you're having will go away.

@bryce-admin
Copy link
Author

Will there be a migration path for this feature (i.e., would #tags in existing bookmarks be copied into it), or would it be an "every bookmarks following that upgrade will have it" sort of thing?

@cdevroe
Copy link
Owner

cdevroe commented Oct 28, 2016

@bryce-admin All tags are already stored in a tag index... they are not only managed via that text area. So yes, they will all come along for the ride.

@cdevroe
Copy link
Owner

cdevroe commented Jan 28, 2019

I'm going to close this as tags will be getting proper treatment in an upcoming release.

@cdevroe cdevroe closed this as completed Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants